iio: ad9523: Fix return value for ad952x_store()
authorLars-Peter Clausen <lars@metafoo.de>
Fri, 27 Jul 2018 06:42:45 +0000 (09:42 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 9 Sep 2018 17:55:56 +0000 (19:55 +0200)
commit 9a5094ca29ea9b1da301b31fd377c0c0c4c23034 upstream.

A sysfs write callback function needs to either return the number of
consumed characters or an error.

The ad952x_store() function currently returns 0 if the input value was "0",
this will signal that no characters have been consumed and the function
will be called repeatedly in a loop indefinitely. Fix this by returning
number of supplied characters to indicate that the whole input string has
been consumed.

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
Fixes: cd1678f96329 ("iio: frequency: New driver for AD9523 SPI Low Jitter Clock Generator")
Cc: <Stable@vger.kernel.org>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/iio/frequency/ad9523.c

index cb45fa314a92e3ac2e5ca2f2d03de1918b8cda5c..1642b55f70da3ab28fa604c3e373bbab429ac593 100644 (file)
@@ -508,7 +508,7 @@ static ssize_t ad9523_store(struct device *dev,
                return ret;
 
        if (!state)
-               return 0;
+               return len;
 
        mutex_lock(&indio_dev->mlock);
        switch ((u32)this_attr->address) {