ASoC: sgtl5000: Use the preferred form for passing a size of a struct
authorFabio Estevam <fabio.estevam@freescale.com>
Fri, 24 Oct 2014 15:01:25 +0000 (13:01 -0200)
committerMark Brown <broonie@kernel.org>
Tue, 28 Oct 2014 00:44:00 +0000 (00:44 +0000)
According to Documentation/CodingStyle - Chapter 14:

"The preferred form for passing a size of a struct is the following:

p = kmalloc(sizeof(*p), ...);

The alternative form where struct name is spelled out hurts readability and
introduces an opportunity for a bug when the pointer variable type is changed
but the corresponding sizeof that is passed to a memory allocator is not."

So do it as recommeded.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/sgtl5000.c

index 59336f6aba8081ac49b1f2b436215cc4d282ce55..490404c6b4d8a2a9ff307077c5617ec9b5791da4 100644 (file)
@@ -1439,8 +1439,7 @@ static int sgtl5000_i2c_probe(struct i2c_client *client,
        struct device_node *np = client->dev.of_node;
        u32 value;
 
-       sgtl5000 = devm_kzalloc(&client->dev, sizeof(struct sgtl5000_priv),
-                                                               GFP_KERNEL);
+       sgtl5000 = devm_kzalloc(&client->dev, sizeof(*sgtl5000), GFP_KERNEL);
        if (!sgtl5000)
                return -ENOMEM;