net: fec: fix missing napi_disable call
authorGeorg Hofmann <georg@hofmannsweb.com>
Thu, 14 Mar 2013 06:54:09 +0000 (06:54 +0000)
committerDavid S. Miller <davem@davemloft.net>
Fri, 15 Mar 2013 12:46:49 +0000 (08:46 -0400)
Commit dc975382d2ef36be7e78fac3717927de1a5abcd8 introduces napi support
but never calls napi_disable. This will generate a kernel oops
(kernel BUG at include/linux/netdevice.h:473!) every time, when
ndo_stop is called followed by ndo_start.
Add the missing napi_diable call.

Signed-off-by: Georg Hofmann <georg@hofmannsweb.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/freescale/fec.c

index 61d2e6202bf378be429ed54b6577574ce7242b12..e3f39372ce25f93b63f93021a68e4dc4bc7294fb 100644 (file)
@@ -1441,6 +1441,7 @@ fec_enet_close(struct net_device *ndev)
        struct fec_enet_private *fep = netdev_priv(ndev);
 
        /* Don't know what to do yet. */
+       napi_disable(&fep->napi);
        fep->opened = 0;
        netif_stop_queue(ndev);
        fec_stop(ndev);