firmware: vpd: use kdtrndup when copying section key

Instead of open-coding kstrndup with kzalloc + memcpy, let's use
the helper.

Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Reviewed-by: Guenter Roeck <groeck@chromium.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/firmware/google/vpd.c b/drivers/firmware/google/vpd.c
index 1e7860f02f4fa99e821e6a71bec7758621bc9a7d..8bd51eaededda7eff7c25643d112c803d319e902 100644 (file)
--- a/drivers/firmware/google/vpd.c
+++ b/drivers/firmware/google/vpd.c
@@ -118,14 +118,13 @@ static int vpd_section_attrib_add(const u8 *key, s32 key_len,
        info = kzalloc(sizeof(*info), GFP_KERNEL);
        if (!info)
                return -ENOMEM;
-       info->key = kzalloc(key_len + 1, GFP_KERNEL);
+
+       info->key = kstrndup(key, key_len, GFP_KERNEL);
        if (!info->key) {
                ret = -ENOMEM;
                goto free_info;
        }
 
-       memcpy(info->key, key, key_len);
-
        sysfs_bin_attr_init(&info->bin_attr);
        info->bin_attr.attr.name = info->key;
        info->bin_attr.attr.mode = 0444;