mtd: map: Fix compilation warning
authorViresh Kumar <viresh.kumar@linaro.org>
Mon, 29 Oct 2012 17:17:26 +0000 (22:47 +0530)
committerArtem Bityutskiy <Artem.Bityutskiy@linux.intel.com>
Thu, 15 Nov 2012 17:50:30 +0000 (19:50 +0200)
This patch is an attempt to fix following compilation warning.

In file included from drivers/mtd/chips/cfi_cmdset_0001.c:35:0:
drivers/mtd/chips/cfi_cmdset_0001.c: In function 'cfi_intelext_write_words':
include/linux/mtd/map.h:331:11: warning: 'r.x[0]' may be used uninitialized in this function [-Wmaybe-uninitialized]

I could have used uninitialized_var() too, but didn't used it as the final else
part of map_word_load() is missing. So there is a chance that it might be passed
uninitialized. Better initialize to zero.

Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
include/linux/mtd/map.h

index 3595a0236b0f9d8de9f7dbdae19d089b1b2adb9d..56c7936e0c6561c3bac903d06304ce18f11b209c 100644 (file)
@@ -328,7 +328,7 @@ static inline int map_word_bitsset(struct map_info *map, map_word val1, map_word
 
 static inline map_word map_word_load(struct map_info *map, const void *ptr)
 {
-       map_word r;
+       map_word r = {{0} };
 
        if (map_bankwidth_is_1(map))
                r.x[0] = *(unsigned char *)ptr;