mmc: sdhci: host: fix odd_ptr_err.cocci warnings
authorWu Fengguang <fengguang.wu@intel.com>
Wed, 21 Jan 2015 11:19:45 +0000 (19:19 +0800)
committerUlf Hansson <ulf.hansson@linaro.org>
Wed, 21 Jan 2015 11:33:43 +0000 (12:33 +0100)
drivers/mmc/host/sdhci_f_sdh30.c:143:5-11: inconsistent IS_ERR and PTR_ERR, PTR_ERR on line 144

 PTR_ERR should access the value just tested by IS_ERR

Semantic patch information:
 There can be false positives in the patch case, where it is the call
 IS_ERR that is wrong.

Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci

CC: Vincent Yang <vincent.yang.fujitsu@gmail.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/mmc/host/sdhci_f_sdh30.c

index c1bb156445e4657084878e28d8e9576bdf612f65..2fe8b91481b3880fd3885834c25fd4b9f05b316b 100644 (file)
@@ -141,7 +141,7 @@ static int sdhci_f_sdh30_probe(struct platform_device *pdev)
        res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
        host->ioaddr = devm_ioremap_resource(&pdev->dev, res);
        if (IS_ERR(host->ioaddr)) {
-               ret = PTR_ERR(host);
+               ret = PTR_ERR(host->ioaddr);
                goto err;
        }