bnx2x: smp_mb and not just smp_rmb
authorEilon Greenstein <eilong@broadcom.com>
Thu, 12 Feb 2009 08:37:25 +0000 (08:37 +0000)
committerDavid S. Miller <davem@davemloft.net>
Mon, 16 Feb 2009 07:31:46 +0000 (23:31 -0800)
Signed-off-by: Eilon Greenstein <eilong@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/bnx2x_main.c

index 6bd92199db211aaa57c7d06c54d085f053bfbc54..2e95799a0db24378f86f5b6651b0de62f1856e44 100644 (file)
@@ -7173,7 +7173,7 @@ static int bnx2x_nic_unload(struct bnx2x *bp, int unload_mode)
                struct bnx2x_fastpath *fp = &bp->fp[i];
 
                cnt = 1000;
-               smp_rmb();
+               smp_mb();
                while (bnx2x_has_tx_work_unload(fp)) {
 
                        bnx2x_tx_int(fp, 1000);
@@ -7189,7 +7189,7 @@ static int bnx2x_nic_unload(struct bnx2x *bp, int unload_mode)
                        }
                        cnt--;
                        msleep(1);
-                       smp_rmb();
+                       smp_mb();
                }
        }
        /* Give HW time to discard old tx messages */