usbip: vudc: fix: Clear already_seen flag also for ep0
authorKrzysztof Opasiak <k.opasiak@samsung.com>
Thu, 1 Dec 2016 18:14:37 +0000 (19:14 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 5 Dec 2016 14:08:45 +0000 (15:08 +0100)
ep_list inside gadget structure doesn't contain ep0.
It is stored separately in ep0 field.

This causes an urb hang if gadget driver decides to
delay setup handling. On host side this is visible as
timeout error when setting configuration.

This bug can be reproduced using for example any gadget
with mass storage function.

Fixes: abdb29574322 ("usbip: vudc: Add vudc_transfer")
Signed-off-by: Krzysztof Opasiak <k.opasiak@samsung.com>
Cc: stable <stable@vger.kernel.org>
Acked-by: Shuah Khan <shuahkh@osg.samsung.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/usbip/vudc_transfer.c

index 8b3dacc9018300daec2d07bb3e02c8d07eb0c77f..4cfd475ee86532c9fb6bb793f9aeda789694e3b5 100644 (file)
@@ -339,6 +339,8 @@ static void v_timer(unsigned long _vudc)
                total = timer->frame_limit;
        }
 
+       /* We have to clear ep0 flags separately as it's not on the list */
+       udc->ep[0].already_seen = 0;
        list_for_each_entry(_ep, &udc->gadget.ep_list, ep_list) {
                ep = to_vep(_ep);
                ep->already_seen = 0;