net: sctp: minor: remove dead code from sctp_packet

struct sctp_packet is currently embedded into sctp_transport or
sits on the stack as 'singleton' in sctp_outq_flush(). Therefore,
its member 'malloced' is always 0, thus a kfree() is never called.
Because of that, we can just remove this code.

Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/include/net/sctp/structs.h b/include/net/sctp/structs.h
index 64d469845f2527720753020b790285317dd95a41..1bd4c4144fe8b7c360ec45900b1e35018d0c1662 100644 (file)
--- a/include/net/sctp/structs.h
+++ b/include/net/sctp/structs.h
@@ -714,8 +714,7 @@ struct sctp_packet {
            has_sack:1,         /* This packet contains a SACK chunk. */
            has_auth:1,         /* This packet contains an AUTH chunk */
            has_data:1,         /* This packet contains at least 1 DATA chunk */
-           ipfragok:1,         /* So let ip fragment this packet */
-           malloced:1;         /* Is it malloced? */
+           ipfragok:1;         /* So let ip fragment this packet */
 };
 
 struct sctp_packet *sctp_packet_init(struct sctp_packet *,

diff --git a/net/sctp/output.c b/net/sctp/output.c
index f5200a2ad852e0ac9e14593a070fac3ad6e66558..bbef4a7a9b569f1d639bf0fe4b2bbef8a5296951 100644 (file)
--- a/net/sctp/output.c
+++ b/net/sctp/output.c
@@ -136,7 +136,7 @@ struct sctp_packet *sctp_packet_init(struct sctp_packet *packet,
        packet->overhead = overhead;
        sctp_packet_reset(packet);
        packet->vtag = 0;
-       packet->malloced = 0;
+
        return packet;
 }
 
@@ -151,9 +151,6 @@ void sctp_packet_free(struct sctp_packet *packet)
                list_del_init(&chunk->list);
                sctp_chunk_free(chunk);
        }
-
-       if (packet->malloced)
-               kfree(packet);
 }
 
 /* This routine tries to append the chunk to the offered packet. If adding