perf hists browser: React to unassigned hotkey pressing
authorArnaldo Carvalho de Melo <acme@redhat.com>
Fri, 19 Jun 2015 20:49:29 +0000 (17:49 -0300)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Fri, 19 Jun 2015 21:14:05 +0000 (18:14 -0300)
When that happens we were just ignoring the key press, now this
message is presented in the bottom line (the help line):

  "Press '?' for help on key bindings"

Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Borislav Petkov <bp@suse.de>
Cc: David Ahern <dsahern@gmail.com>
Cc: Don Zickus <dzickus@redhat.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Stephane Eranian <eranian@google.com>
Link: http://lkml.kernel.org/n/tip-iyma2j5kj3q9i1stl4mfh90n@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/ui/browsers/hists.c

index e2b500b265274c12bba3b50de094da7aafeb04dd..c42adb6000914554bf0d109e02d9ad5cec801313 100644 (file)
@@ -1902,10 +1902,11 @@ static int perf_evsel__hists_browse(struct perf_evsel *evsel, int nr_events,
                case CTRL('c'):
                        goto out_free_stack;
                case 'f':
-                       if (is_report_browser(hbt))
-                               continue;
-                       goto out_free_stack;
+                       if (!is_report_browser(hbt))
+                               goto out_free_stack;
+                       /* Fall thru */
                default:
+                       helpline = "Press '?' for help on key bindings";
                        continue;
                }