ASoC: wm8955: harmless underflow in wm8955_put_deemph()
authorDan Carpenter <dan.carpenter@oracle.com>
Tue, 13 Oct 2015 07:10:48 +0000 (10:10 +0300)
committerMark Brown <broonie@kernel.org>
Thu, 22 Oct 2015 12:57:39 +0000 (13:57 +0100)
Valid values for "deemph" are zero and one, but we mistakenly allow
negative values as well.  It's harmless but we may as well clean it up.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/wm8955.c

index 12e4435f00f85507340305442747119f8feb5208..9db00d53abe76f58be4e74a4b4e5342c3a19147d 100644 (file)
@@ -402,7 +402,7 @@ static int wm8955_put_deemph(struct snd_kcontrol *kcontrol,
 {
        struct snd_soc_codec *codec = snd_soc_kcontrol_codec(kcontrol);
        struct wm8955_priv *wm8955 = snd_soc_codec_get_drvdata(codec);
-       int deemph = ucontrol->value.integer.value[0];
+       unsigned int deemph = ucontrol->value.integer.value[0];
 
        if (deemph > 1)
                return -EINVAL;