[ALSA] ad1848 double free
authorDave Jones <davej@redhat.com>
Mon, 6 Mar 2006 12:31:18 +0000 (13:31 +0100)
committerJaroslav Kysela <perex@suse.cz>
Wed, 22 Mar 2006 09:36:08 +0000 (10:36 +0100)
Modules: AD1848 driver

Same again, snd_ctl_add() already kfree's on error.

Coverity #956

Signed-off-by: Dave Jones <davej@redhat.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/isa/ad1848/ad1848_lib.c

index d4b0e580557ede576820ecfe9f429f2121e0043c..e0f8baa843b9c02cc31314f2cb149d98e41d8043 100644 (file)
@@ -1202,10 +1202,8 @@ int snd_ad1848_add_ctl(struct snd_ad1848 *chip, const char *name, int index, int
        strlcpy(ctl->id.name, name, sizeof(ctl->id.name));
        ctl->id.index = index;
        ctl->private_value = value;
-       if ((err = snd_ctl_add(chip->card, ctl)) < 0) {
-               snd_ctl_free_one(ctl);
+       if ((err = snd_ctl_add(chip->card, ctl)) < 0)
                return err;
-       }
        return 0;
 }