cpufreq: arm-big-little: call CPUFREQ_POSTCHANGE notfier in error cases
authorViresh Kumar <viresh.kumar@linaro.org>
Wed, 19 Jun 2013 05:48:20 +0000 (11:18 +0530)
committerViresh Kumar <viresh.kumar@linaro.org>
Mon, 24 Jun 2013 12:48:58 +0000 (18:18 +0530)
PRECHANGE and POSTCHANGE notifiers must be called in groups, i.e either both
should be called or both shouldn't be.

In case we have started PRECHANGE notifier and found an error, we must call
POSTCHANGE notifier with freqs.new = freqs.old to guarantee that sequence of
calling notifiers is complete.

This patch fixes it.

This also removes code setting policy->cur as this is also done by POSTCHANGE
notifier.

Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
drivers/cpufreq/arm_big_little.c

index 5d7f53fcd6f5eac052d4a0bfed4d48f531921d8c..3549f0784af176d07ee17dd60d02ec85859d6bd1 100644 (file)
@@ -84,11 +84,9 @@ static int bL_cpufreq_set_target(struct cpufreq_policy *policy,
        ret = clk_set_rate(clk[cur_cluster], freqs.new * 1000);
        if (ret) {
                pr_err("clk_set_rate failed: %d\n", ret);
-               return ret;
+               freqs.new = freqs.old;
        }
 
-       policy->cur = freqs.new;
-
        cpufreq_notify_transition(policy, &freqs, CPUFREQ_POSTCHANGE);
 
        return ret;