KVM: s390: Fix vcpu_load handling in interrupt code
authorChristian Borntraeger <borntraeger@de.ibm.com>
Thu, 27 Sep 2012 15:29:45 +0000 (17:29 +0200)
committerAvi Kivity <avi@redhat.com>
Thu, 27 Sep 2012 16:19:53 +0000 (18:19 +0200)
Recent changes (KVM: make processes waiting on vcpu mutex killable)
now requires to check the return value of vcpu_load. This triggered
a warning in s390 specific kvm code. Turns out that we can actually
remove the put/load, since schedule will do the right thing via
the preempt notifiers.

Reported-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
Signed-off-by: Avi Kivity <avi@redhat.com>
arch/s390/kvm/interrupt.c

index 7556231fb073f919c9f89b97cbddc3e60b169da5..ff1e2f8ef94a02146e9b90e56c7105f9e9b140f3 100644 (file)
@@ -423,9 +423,7 @@ no_timer:
                set_current_state(TASK_INTERRUPTIBLE);
                spin_unlock_bh(&vcpu->arch.local_int.lock);
                spin_unlock(&vcpu->arch.local_int.float_int->lock);
-               vcpu_put(vcpu);
                schedule();
-               vcpu_load(vcpu);
                spin_lock(&vcpu->arch.local_int.float_int->lock);
                spin_lock_bh(&vcpu->arch.local_int.lock);
        }