platform/x86: ideapad-laptop: Squelch ACPI event 1
authorHao Wei Tee <angelsl@angelsl.xyz>
Mon, 22 May 2017 10:38:55 +0000 (18:38 +0800)
committerAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Tue, 23 May 2017 16:36:25 +0000 (19:36 +0300)
Don't simply throw this to userspace via the sparse_keymap (which does not
have a mapping for scancode 1), as this causes KEY_UNKNOWN to be emitted,
which is a nuisance and of no use at all (it is not the right way to expose
this ACPI event to userspace, anyway, and the original intention of the commit
which added this (cfee5d63767b2e7997c1f36420d008abbe61565c) was only to suppress
an unhandled event log message).

Signed-off-by: Hao Wei Tee <angelsl@angelsl.xyz>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
drivers/platform/x86/ideapad-laptop.c

index e4c83c15587d139720d2fcbbbed9019a5d19346a..d4896256936436f9b80e0ea0d76942c061ceb35b 100644 (file)
@@ -844,7 +844,6 @@ static void ideapad_acpi_notify(acpi_handle handle, u32 event, void *data)
                        case 8:
                        case 7:
                        case 6:
-                       case 1:
                                ideapad_input_report(priv, vpc_bit);
                                break;
                        case 5:
@@ -862,6 +861,13 @@ static void ideapad_acpi_notify(acpi_handle handle, u32 event, void *data)
                        case 0:
                                ideapad_check_special_buttons(priv);
                                break;
+                       case 1:
+                               /* Some IdeaPads report event 1 every ~20
+                                * seconds while on battery power; some
+                                * report this when changing to/from tablet
+                                * mode. Squelch this event.
+                                */
+                               break;
                        default:
                                pr_info("Unknown event: %lu\n", vpc_bit);
                        }