projects / GitHub / exynos8895 / android_kernel_samsung_universal8895.git / commitdiff
? search:
summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: 081c7a8)
ath6kl: Return a proper error code when not in connected state
authorRaja Mani <rmani@qca.qualcomm.com>
Mon, 30 Jan 2012 11:43:12 +0000 (17:13 +0530)
committerKalle Valo <kvalo@qca.qualcomm.com>
Mon, 30 Jan 2012 19:22:55 +0000 (21:22 +0200)
Error code ENOTCONN is more suitable than EINVAL to report
when the driver is not in connected state in ath6kl_wow_suspend().

I found this during code review.

Signed-off-by: Raja Mani <rmani@qca.qualcomm.com>
Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
drivers/net/wireless/ath/ath6kl/cfg80211.c patch | blob | blame | history

diff --git a/drivers/net/wireless/ath/ath6kl/cfg80211.c b/drivers/net/wireless/ath/ath6kl/cfg80211.c
index 1902e2fa1a68949988eae8eb82d449dabf7d1a19..5934e40ee55da0eb4e37bbb63968d79543ba16c2 100644 (file)
--- a/drivers/net/wireless/ath/ath6kl/cfg80211.c
+++ b/drivers/net/wireless/ath/ath6kl/cfg80211.c
@@ -1916,7 +1916,7 @@ static int ath6kl_wow_suspend(struct ath6kl *ar, struct cfg80211_wowlan *wow)
                return -EIO;
 
        if (!test_bit(CONNECTED, &vif->flags))
-               return -EINVAL;
+               return -ENOTCONN;
 
        if (wow && (wow->n_patterns > WOW_MAX_FILTERS_PER_LIST))
                return -EINVAL;