mlxsw: Use correct skb length when dumping payload
authorIdo Schimmel <idosch@mellanox.com>
Thu, 6 Aug 2015 14:41:57 +0000 (16:41 +0200)
committerDavid S. Miller <davem@davemloft.net>
Mon, 10 Aug 2015 05:54:10 +0000 (22:54 -0700)
Do not use the length of the transmitted skb (which was freed), but
that of the response skb.

This issue was discovered using the Kernel Address sanitizer (KASan).

Signed-off-by: Ido Schimmel <idosch@mellanox.com>
Signed-off-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/mellanox/mlxsw/core.c

index 7562802bc6c8e7f5e74ea25cb7f53bb85cda82ad..09325b72d52409dbb5528aa139aa44e1a3ddd873 100644 (file)
@@ -1073,7 +1073,7 @@ static int mlxsw_core_reg_access_emad(struct mlxsw_core *mlxsw_core,
                        mlxsw_core->emad.tid - 1);
                mlxsw_core_buf_dump_dbg(mlxsw_core,
                                        mlxsw_core->emad.resp_skb->data,
-                                       skb->len);
+                                       mlxsw_core->emad.resp_skb->len);
 
                dev_kfree_skb(mlxsw_core->emad.resp_skb);
        }