hwmon: (stts751) buffer overrun on wrong chip configuration

If stts751 hw by some reason reports conversion rate bigger then 9:
        ret = i2c_smbus_read_byte_data(priv->client, STTS751_REG_RATE);
then dereferencing stts751_intervals[priv->interval] leads to buffer
overrun.

The patch adds sanity check for value stored on chip.

Found by Linux Driver Verification project (linuxtesting.org).

Fixes: 7f07ec0fa17a ("hwmon: new driver for ST stts751 thermal sensor")
Signed-off-by: Anton Vasilyev <vasilyev@ispras.ru>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>

diff --git a/drivers/hwmon/stts751.c b/drivers/hwmon/stts751.c
index d56251d6eec2e49fcf43bc74b20306896e1f0e73..3f940fb67dc622cc096745b9e6950e68f73d6b73 100644 (file)
--- a/drivers/hwmon/stts751.c
+++ b/drivers/hwmon/stts751.c
@@ -718,6 +718,10 @@ static int stts751_read_chip_config(struct stts751_priv *priv)
        ret = i2c_smbus_read_byte_data(priv->client, STTS751_REG_RATE);
        if (ret < 0)
                return ret;
+       if (ret >= ARRAY_SIZE(stts751_intervals)) {
+               dev_err(priv->dev, "Unrecognized conversion rate 0x%x\n", ret);
+               return -ENODEV;
+       }
        priv->interval = ret;
 
        ret = stts751_read_reg16(priv, &priv->event_max,