greybus: minor checkpatch cleanups

diff --git a/drivers/staging/greybus/core.c b/drivers/staging/greybus/core.c
index bbe9ef96a4f89ac118a57a910ccb30368ae1fc0f..da62baf764a28333974cb48d03e5ad2a113d9a15 100644 (file)
--- a/drivers/staging/greybus/core.c
+++ b/drivers/staging/greybus/core.c
@@ -226,8 +226,9 @@ error_i2c:
        return retval;
 }
 
-static const struct greybus_module_id fake_gb_id =
-       { GREYBUS_DEVICE(0x42, 0x42) };
+static const struct greybus_module_id fake_gb_id = {
+       GREYBUS_DEVICE(0x42, 0x42)
+};
 
 static int create_function(struct greybus_device *gdev,
                           struct greybus_descriptor *desc, int desc_size)

diff --git a/drivers/staging/greybus/gpio-gb.c b/drivers/staging/greybus/gpio-gb.c
index c4cb6a2f34c929ba0a8186aa582139b5e8dabbbb..3428220c5158599d417e202426110fa862a82633 100644 (file)
--- a/drivers/staging/greybus/gpio-gb.c
+++ b/drivers/staging/greybus/gpio-gb.c
@@ -48,7 +48,6 @@ static int gpio_get(struct gpio_chip *gpio, unsigned nr)
 static void gpio_set(struct gpio_chip *gpio, unsigned nr, int val)
 {
        // FIXME - do something there
-       return;
 }
 
 int gb_gpio_probe(struct greybus_device *gdev,
@@ -77,7 +76,7 @@ int gb_gpio_probe(struct greybus_device *gdev,
        gpio->ngpio = 42;               // FIXME!!!
        gpio->can_sleep = false;        // FIXME!!!
 
-       gdev->gb_gpio_dev= gb_gpio;
+       gdev->gb_gpio_dev = gb_gpio;
 
        retval = gpiochip_add(gpio);
        if (retval) {

diff --git a/drivers/staging/greybus/sysfs.c b/drivers/staging/greybus/sysfs.c
index 16e6ca4f9200d359cb2a5c737faf94f2f0d8669d..2393a6a0b678c430f351e1a403540693fe65b2bc 100644 (file)
--- a/drivers/staging/greybus/sysfs.c
+++ b/drivers/staging/greybus/sysfs.c
@@ -85,6 +85,7 @@ static ssize_t module_vendor_string_show(struct device *dev,
                                         char *buf)
 {
        struct greybus_device *gdev = to_greybus_device(dev);
+
        return sprintf(buf, "%s",
                       greybus_string(gdev, gdev->module_id.vendor_stringid));
 }
@@ -95,6 +96,7 @@ static ssize_t module_product_string_show(struct device *dev,
                                         char *buf)
 {
        struct greybus_device *gdev = to_greybus_device(dev);
+
        return sprintf(buf, "%s",
                       greybus_string(gdev, gdev->module_id.product_stringid));
 }
@@ -141,6 +143,7 @@ static ssize_t serial_number_show(struct device *dev,
                                  struct device_attribute *attr, char *buf)
 {
        struct greybus_device *gdev = to_greybus_device(dev);
+
        return sprintf(buf, "%llX\n",
                      (unsigned long long)gdev->serial_number.serial_number);
 }

diff --git a/drivers/staging/greybus/uart-gb.c b/drivers/staging/greybus/uart-gb.c
index d104d9cc1221361284c6f9f4245577fae80bd3a1..896d50124a9adfba608ad3c92a08acdbdf00dd45 100644 (file)
--- a/drivers/staging/greybus/uart-gb.c
+++ b/drivers/staging/greybus/uart-gb.c
@@ -245,8 +245,7 @@ static int get_serial_info(struct gb_tty *gb_tty,
 
        if (copy_to_user(info, &tmp, sizeof(tmp)))
                return -EFAULT;
-       else
-               return 0;
+       return 0;
 }
 
 static int set_serial_info(struct gb_tty *gb_tty,