projects / GitHub / LineageOS / G12 / android_kernel_amlogic_linux-4.9.git / commitdiff
? search:
summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: 135f07c)
serial: samsung: correct the case and default order in switch
authorNaveen Krishna Chatradhi <ch.naveen@samsung.com>
Mon, 14 Jul 2014 11:37:17 +0000 (17:07 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 18 Jul 2014 01:18:22 +0000 (18:18 -0700)
The cases should comes before default in a switch.

Even if we want the case and default to share same code.
Its good to define the case first followed by default.

Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com>
Reviewed-by: Tomasz Figa <t.figa@samsung.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/samsung.c patch | blob | blame | history

diff --git a/drivers/tty/serial/samsung.c b/drivers/tty/serial/samsung.c
index e49a9451976e34e015af0eaca6235324d9b2cd6b..d98f93db85f9cb3bbcfb2bd3e83519c32092e8f6 100644 (file)
--- a/drivers/tty/serial/samsung.c
+++ b/drivers/tty/serial/samsung.c
@@ -1542,8 +1542,8 @@ s3c24xx_serial_get_options(struct uart_port *port, int *baud,
                case S3C2410_LCON_CS7:
                        *bits = 7;
                        break;
-               default:
                case S3C2410_LCON_CS8:
+               default:
                        *bits = 8;
                        break;
                }