cpufreq: Always update current frequency before startig governor
authorRafael J. Wysocki <rafael.j.wysocki@intel.com>
Mon, 21 Mar 2016 14:47:48 +0000 (15:47 +0100)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Tue, 22 Mar 2016 22:13:36 +0000 (23:13 +0100)
Make policy->cur match the current frequency returned by the driver's
->get() callback before starting the governor in case they went out of
sync in the meantime and drop the piece of code attempting to
resync policy->cur with the real frequency of the boot CPU from
cpufreq_resume() as it serves no purpose any more (and it's racy and
super-ugly anyway).

Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
drivers/cpufreq/cpufreq.c

index ffdb7fca5bb7b2bf5be757406ea03aa143ed2e15..b87596b591b3ca9fdf332884700e5a3cc96ebf10 100644 (file)
@@ -1612,17 +1612,6 @@ void cpufreq_resume(void)
                                       __func__, policy);
                }
        }
-
-       /*
-        * schedule call cpufreq_update_policy() for first-online CPU, as that
-        * wouldn't be hotplugged-out on suspend. It will verify that the
-        * current freq is in sync with what we believe it to be.
-        */
-       policy = cpufreq_cpu_get_raw(cpumask_first(cpu_online_mask));
-       if (WARN_ON(!policy))
-               return;
-
-       schedule_work(&policy->update);
 }
 
 /**
@@ -1950,6 +1939,9 @@ static int cpufreq_start_governor(struct cpufreq_policy *policy)
 {
        int ret;
 
+       if (cpufreq_driver->get && !cpufreq_driver->setpolicy)
+               cpufreq_update_current_freq(policy);
+
        ret = cpufreq_governor(policy, CPUFREQ_GOV_START);
        return ret ? ret : cpufreq_governor(policy, CPUFREQ_GOV_LIMITS);
 }