net: phy: fix sign type error in genphy_config_eee_advert
authorjbrunet <jbrunet@baylibre.com>
Mon, 19 Dec 2016 15:05:36 +0000 (16:05 +0100)
committerDavid S. Miller <davem@davemloft.net>
Tue, 20 Dec 2016 18:50:49 +0000 (13:50 -0500)
In genphy_config_eee_advert, the return value of phy_read_mmd_indirect is
checked to know if the register could be accessed but the result is
assigned to a 'u32'.
Changing to 'int' to correctly get errors from phy_read_mmd_indirect.

Fixes: d853d145ea3e ("net: phy: add an option to disable EEE advertisement")
Reported-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/phy/phy_device.c

index 9c06f8028f0c349629365cbdc82f63f63b55c098..ee5ebadb14637ede6c3beff2a200dfc89ce47176 100644 (file)
@@ -1187,8 +1187,8 @@ static int genphy_config_advert(struct phy_device *phydev)
  */
 static int genphy_config_eee_advert(struct phy_device *phydev)
 {
-       u32 broken = phydev->eee_broken_modes;
-       u32 old_adv, adv;
+       int broken = phydev->eee_broken_modes;
+       int old_adv, adv;
 
        /* Nothing to disable */
        if (!broken)