projects
/
GitHub
/
MotorolaMobilityLLC
/
kernel-slsi.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
d2adcaa
)
act_police: remove unnecessary null pointer check
author
Yang Yingliang
<yangyingliang@huawei.com>
Tue, 17 Dec 2013 07:29:16 +0000
(15:29 +0800)
committer
David S. Miller
<davem@davemloft.net>
Thu, 19 Dec 2013 20:06:55 +0000
(15:06 -0500)
It already has a NULL pointer check of rtab in qdisc_put_rtab().
Remove the check outside of qdisc_put_rtab().
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/sched/act_police.c
patch
|
blob
|
blame
|
history
diff --git
a/net/sched/act_police.c
b/net/sched/act_police.c
index 0cc305e7e4690043e3228c8425f73d384c51bf69..7b23ab07c6cc19bfb3d3fa0e028f50bbda3cdbc8 100644
(file)
--- a/
net/sched/act_police.c
+++ b/
net/sched/act_police.c
@@
-261,10
+261,8
@@
override:
failure_unlock:
spin_unlock_bh(&police->tcf_lock);
failure:
- if (P_tab)
- qdisc_put_rtab(P_tab);
- if (R_tab)
- qdisc_put_rtab(R_tab);
+ qdisc_put_rtab(P_tab);
+ qdisc_put_rtab(R_tab);
if (ret == ACT_P_CREATED)
kfree(police);
return err;