staging: unisys: visorbus: get rid of shouting SPAR_VBUS_CHANNEL_CLIENT_OK macro
authorDavid Kershner <david.kershner@unisys.com>
Tue, 28 Mar 2017 13:34:41 +0000 (09:34 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 29 Mar 2017 07:17:03 +0000 (09:17 +0200)
The macro SPAR_VBUS_CHANNEL_CLIENT_OK was noisy and only used in one place
so get rid of it.

Signed-off-by: David Kershner <david.kershner@unisys.com>
Reviewed-by: Reviewed-by: Tim Sell <timothy.sell@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/unisys/visorbus/vbuschannel.h
drivers/staging/unisys/visorbus/visorbus_main.c

index 4ef70fd90a2d39f39c97ce329af0f7666bcbc071..f0ef5ecf3d7d25098de2c106c43ac0029785bb74 100644 (file)
@@ -43,14 +43,6 @@ static const uuid_le spar_vbus_channel_protocol_uuid =
  */
 #define SPAR_VBUS_CHANNEL_PROTOCOL_VERSIONID 1
 
-#define SPAR_VBUS_CHANNEL_OK_CLIENT(ch) \
-       spar_check_channel_client(ch, \
-                                 spar_vbus_channel_protocol_uuid, \
-                                 "vbus", \
-                                 sizeof(struct spar_vbus_channel_protocol), \
-                                 SPAR_VBUS_CHANNEL_PROTOCOL_VERSIONID, \
-                                 SPAR_VBUS_CHANNEL_PROTOCOL_SIGNATURE)
-
 /*
  * An array of this struct is present in the channel area for each vbus.
  * (See vbuschannel.h.)
index 094a60e53984b6e3dd173a32172b0e1491c89d91..8b434b0d73b88e8e6f9bfa73e19435cfe4641ef2 100644 (file)
@@ -699,7 +699,13 @@ static int
 get_vbus_header_info(struct visorchannel *chan,
                     struct spar_vbus_headerinfo *hdr_info)
 {
-       if (!SPAR_VBUS_CHANNEL_OK_CLIENT(visorchannel_get_header(chan)))
+       if (!spar_check_channel_client(visorchannel_get_header(chan),
+                                      spar_vbus_channel_protocol_uuid,
+                                      "vbus",
+                                      sizeof
+                                           (struct spar_vbus_channel_protocol),
+                                      SPAR_VBUS_CHANNEL_PROTOCOL_VERSIONID,
+                                      SPAR_VBUS_CHANNEL_PROTOCOL_SIGNATURE))
                return -EINVAL;
 
        if (visorchannel_read(chan, sizeof(struct channel_header), hdr_info,