Remove broken check for UserGroupPermissionCache consistency

The purpose of this check is not entirely clear, as it exists since the very
first commit in git. Back then it was not yet broken, it got broken when the
caching system was refactored to reorder parameters, probably in order to
improve the cache hit rates:

When running the `worker`s using the CLI interface, for some reason, the cache
for guests gets rebuilt with the `$parameters` array (and thus by extension the
`groupIDs` value) being equal to `[2, 1]`, whereas everywhere else the
`$parameters` are consistently `[1, 2]`.

Now when rebuilding the data via the CLI, the cache will have the `[2, 1]`
order and when reloading the cache in a regular HTTP session this check will
fail, as `[2, 1] != [1, 2]`, thus completely disregarding the cache contents
and using an empty permissions array instead. This in turn leads to guests not
being able to access anything.

Fix this by removing the safety check:

- It's exceedingly unlikely for two unrelated `$parameters` to collide in the
  cache filename, thus applying incorrect permissions.
- If the CacheBuilder itself is buggy, then all bets are off anyway.

diff --git a/wcfsetup/install/files/lib/data/user/UserProfile.class.php b/wcfsetup/install/files/lib/data/user/UserProfile.class.php
index 700d7085d7025af0fa60c86c13097b06b98280c5..f8c2974f114f1b7b447f049dcbeedcd433602d21 100644 (file)
--- a/wcfsetup/install/files/lib/data/user/UserProfile.class.php
+++ b/wcfsetup/install/files/lib/data/user/UserProfile.class.php
@@ -967,11 +967,7 @@ class UserProfile extends DatabaseObjectDecorator implements ITitledLinkObject
      */
     protected function loadGroupData()
     {
-        // get group data from cache
         $this->groupData = UserGroupPermissionCacheBuilder::getInstance()->getData($this->getGroupIDs());
-        if (isset($this->groupData['groupIDs']) && $this->groupData['groupIDs'] != $this->getGroupIDs()) {
-            $this->groupData = [];
-        }
     }
 
     /**

diff --git a/wcfsetup/install/files/lib/system/session/SessionHandler.class.php b/wcfsetup/install/files/lib/system/session/SessionHandler.class.php
index 6ff3fc54bcb7cdf9d07b73cc2cc7a9f118a2608f..2ab7bb3d7e45268283df66b56c561ca1f42c3f6f 100644 (file)
--- a/wcfsetup/install/files/lib/system/session/SessionHandler.class.php
+++ b/wcfsetup/install/files/lib/system/session/SessionHandler.class.php
@@ -860,9 +860,6 @@ final class SessionHandler extends SingletonFactory
 
         // get group data from cache
         $this->groupData = UserGroupPermissionCacheBuilder::getInstance()->getData($groupIDs);
-        if (isset($this->groupData['groupIDs']) && $this->groupData['groupIDs'] != $groupIDs) {
-            $this->groupData = [];
-        }
     }
 
     /**