projects / GitHub / LineageOS / G12 / android_kernel_amlogic_linux-4.9.git / commitdiff
? search:
summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: 21ba005)
ath9k_htc: check for underflow in ath9k_htc_rx_msg()
authorDan Carpenter <dan.carpenter@oracle.com>
Fri, 6 Nov 2015 10:01:20 +0000 (13:01 +0300)
committerKalle Valo <kvalo@codeaurora.org>
Thu, 26 Nov 2015 12:05:17 +0000 (14:05 +0200)
We check for overflow here, but we don't check for underflow so it
causes a static checker warning.

Fixes: fb9987d0f748 ('ath9k_htc: Support for AR9271 chipset.')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
drivers/net/wireless/ath/ath9k/htc_hst.c patch | blob | blame | history

diff --git a/drivers/net/wireless/ath/ath9k/htc_hst.c b/drivers/net/wireless/ath/ath9k/htc_hst.c
index 2294709ee8b0ae62144be926f55f4ac4f10a86c6..fd85f996c5549633a56d525dc134b1f3f141ac17 100644 (file)
--- a/drivers/net/wireless/ath/ath9k/htc_hst.c
+++ b/drivers/net/wireless/ath/ath9k/htc_hst.c
@@ -414,7 +414,7 @@ void ath9k_htc_rx_msg(struct htc_target *htc_handle,
                return;
        }
 
-       if (epid >= ENDPOINT_MAX) {
+       if (epid < 0 || epid >= ENDPOINT_MAX) {
                if (pipe_id != USB_REG_IN_PIPE)
                        dev_kfree_skb_any(skb);
                else