OMAPFB: fix parsing of vram parameter

omapfb_parse_vram_param()'s check for end pointer returned from
simple_strtoul() is wrong, causing the code to bug if the second or
later vram parameters are non-parseable, for example
"omapfb.vram=0:2M,:5M".

However, even in that case the code will most likely bail out with
-EINVAL in the following checks, so the bug is probably not a fatal one.

Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
Reported-by: Hein Tibosch <hein_tibosch@yahoo.es>

diff --git a/drivers/video/omap2/omapfb/omapfb-main.c b/drivers/video/omap2/omapfb/omapfb-main.c
index b00db4068d21c0280631fb1ca5816d4a499501f0..7f02e7f90d63c314d037b1dd6482318c1892d33a 100644 (file)
--- a/drivers/video/omap2/omapfb/omapfb-main.c
+++ b/drivers/video/omap2/omapfb/omapfb-main.c
@@ -1502,7 +1502,7 @@ static int omapfb_parse_vram_param(const char *param, int max_entries,
 
                fbnum = simple_strtoul(p, &p, 10);
 
-               if (p == param)
+               if (p == start)
                        return -EINVAL;
 
                if (*p != ':')