USB: input: xpad.c: fix up dev_err() usage
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 2 May 2012 00:56:34 +0000 (20:56 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 2 May 2012 00:56:34 +0000 (20:56 -0400)
We should always reference the input device for dev_err(), not the USB
device.  Fix up the places where I got this wrong.

Reported-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
CC: "Magnus Hörlin" <magnus@alefors.se>
CC: Rusty Russell <rusty@rustcorp.com.au>
CC: Mauro Carvalho Chehab <mchehab@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/input/joystick/xpad.c

index bee9c00032ee99e12d38e44e24a72ad0e9f5a802..d760031430a35bfc52d2096c3cb65712ba3c820d 100644 (file)
@@ -492,7 +492,7 @@ static void xpad_irq_in(struct urb *urb)
 exit:
        retval = usb_submit_urb(urb, GFP_ATOMIC);
        if (retval)
-               dev_err(&xpad->udev->dev,
+               dev_err(&xpad->dev->dev,
                        "%s - usb_submit_urb failed with result %d\n",
                        __func__, retval);
 }
@@ -542,7 +542,7 @@ static void xpad_irq_out(struct urb *urb)
 exit:
        retval = usb_submit_urb(urb, GFP_ATOMIC);
        if (retval)
-               dev_err(&xpad->udev->dev,
+               dev_err(&xpad->dev->dev,
                        "%s - usb_submit_urb failed with result %d\n",
                        __func__, retval);
 }