KVM: VMX: remove redundant code from vmx_set_segment()
authorGleb Natapov <gleb@redhat.com>
Wed, 12 Dec 2012 17:10:53 +0000 (19:10 +0200)
committerGleb Natapov <gleb@redhat.com>
Sun, 23 Dec 2012 12:01:37 +0000 (14:01 +0200)
Segment descriptor's base is fixed by call to fix_rmode_seg(). Not need
to do it twice.

Reviewed-by: Marcelo Tosatti <mtosatti@redhat.com>
Signed-off-by: Gleb Natapov <gleb@redhat.com>
arch/x86/kvm/vmx.c

index 9e784c2c9782e5ee185db99e361d6a0ccc441404..9b8edd2298e5bfe4b932091bd11e671743984276 100644 (file)
@@ -3268,7 +3268,7 @@ static void vmx_set_segment(struct kvm_vcpu *vcpu,
 {
        struct vcpu_vmx *vmx = to_vmx(vcpu);
        const struct kvm_vmx_segment_field *sf = &kvm_vmx_segment_fields[seg];
-       u32 ar;
+       u32 ar = 0;
 
        vmx_segment_cache_clear(vmx);
 
@@ -3280,15 +3280,9 @@ static void vmx_set_segment(struct kvm_vcpu *vcpu,
        vmcs_writel(sf->base, var->base);
        vmcs_write32(sf->limit, var->limit);
        vmcs_write16(sf->selector, var->selector);
-       if (vmx->rmode.vm86_active && var->s) {
+       if (vmx->rmode.vm86_active && var->s)
                vmx->rmode.segs[seg] = *var;
-               /*
-                * Hack real-mode segments into vm86 compatibility.
-                */
-               if (var->base == 0xffff0000 && var->selector == 0xf000)
-                       vmcs_writel(sf->base, 0xf0000);
-               ar = 0xf3;
-       } else
+       else
                ar = vmx_segment_access_rights(var);
 
        /*