drm/fsl-dcu: unload driver before disabling clocks
authorStefan Agner <stefan@agner.ch>
Thu, 20 Oct 2016 00:32:20 +0000 (17:32 -0700)
committerStefan Agner <stefan@agner.ch>
Tue, 29 Nov 2016 01:18:33 +0000 (17:18 -0800)
Use drm_put_dev to unload the driver before disabling clocks.
Otherwise the driver might read a register during unload which
leads to an external abort.

Signed-off-by: Stefan Agner <stefan@agner.ch>
drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c

index 0b0d1cb11641517073a8822aeb7337f680634cfe..30c46a80a540fde5bd59dcf138fddc527246a70b 100644 (file)
@@ -428,9 +428,9 @@ static int fsl_dcu_drm_remove(struct platform_device *pdev)
 {
        struct fsl_dcu_drm_device *fsl_dev = platform_get_drvdata(pdev);
 
+       drm_put_dev(fsl_dev->drm);
        clk_disable_unprepare(fsl_dev->clk);
        clk_unregister(fsl_dev->pix_clk);
-       drm_put_dev(fsl_dev->drm);
 
        return 0;
 }