pppoatm: do not inline pppoatm_may_send()
authorKrzysztof Mazur <krzysiek@podlesie.net>
Tue, 6 Nov 2012 22:17:02 +0000 (23:17 +0100)
committerDavid Woodhouse <David.Woodhouse@intel.com>
Fri, 30 Nov 2012 12:23:19 +0000 (12:23 +0000)
The pppoatm_may_send() is quite heavy and it's called three times
in pppoatm_send() and inlining costs more than 200 bytes of code
(more than 10% of total pppoatm driver code size).

add/remove: 1/0 grow/shrink: 0/1 up/down: 132/-367 (-235)
function                                     old     new   delta
pppoatm_may_send                               -     132    +132
pppoatm_send                                 900     533    -367

Signed-off-by: Krzysztof Mazur <krzysiek@podlesie.net>
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
net/atm/pppoatm.c

index aeb726cffc8cf4cb3cfc41cca71068c8057c4198..3dce84af5dbe0cea71b5e6c98e19e2dcb791c94d 100644 (file)
@@ -214,7 +214,7 @@ error:
        ppp_input_error(&pvcc->chan, 0);
 }
 
-static inline int pppoatm_may_send(struct pppoatm_vcc *pvcc, int size)
+static int pppoatm_may_send(struct pppoatm_vcc *pvcc, int size)
 {
        /*
         * It's not clear that we need to bother with using atm_may_send()