KVM: Disable interrupts around get_kernel_ns()
authorAvi Kivity <avi@redhat.com>
Mon, 4 Oct 2010 10:55:49 +0000 (12:55 +0200)
committerAvi Kivity <avi@redhat.com>
Sun, 24 Oct 2010 08:53:14 +0000 (10:53 +0200)
get_kernel_ns() wants preemption disabled.  It doesn't make a lot of sense
during the get/set ioctls (no way to make them non-racy) but the callee wants
it.

Signed-off-by: Avi Kivity <avi@redhat.com>
arch/x86/kvm/x86.c

index ffcb90669ec5a41ed05075975511c9a81e1eb070..e96038e1bc3a23ae1b17a5a7a6d38172f8c5d4b0 100644 (file)
@@ -3469,8 +3469,10 @@ long kvm_arch_vm_ioctl(struct file *filp,
                        goto out;
 
                r = 0;
+               local_irq_disable();
                now_ns = get_kernel_ns();
                delta = user_ns.clock - now_ns;
+               local_irq_enable();
                kvm->arch.kvmclock_offset = delta;
                break;
        }
@@ -3478,8 +3480,10 @@ long kvm_arch_vm_ioctl(struct file *filp,
                struct kvm_clock_data user_ns;
                u64 now_ns;
 
+               local_irq_disable();
                now_ns = get_kernel_ns();
                user_ns.clock = kvm->arch.kvmclock_offset + now_ns;
+               local_irq_enable();
                user_ns.flags = 0;
 
                r = -EFAULT;