i2c: ACPI: Pick the first address if device has multiple
authorMika Westerberg <mika.westerberg@linux.intel.com>
Mon, 29 Dec 2014 13:48:48 +0000 (15:48 +0200)
committerWolfram Sang <wsa@the-dreams.de>
Wed, 14 Jan 2015 10:56:06 +0000 (11:56 +0100)
ACPI specification allows I2C devices with multiple addresses. The current
implementation goes over all addresses and assigns the last one to the
device. This is typically not the primary address of the device.

Instead of doing that we assign the first address to the device and then
let the driver handle rest of the addresses as it wishes.

Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
drivers/i2c/i2c-core.c

index 393bb0e8c8f2b820bebd1479b74cecfd51dd2bab..79ac8605936d11715b94adc7bf2e7fe51ae10be1 100644 (file)
@@ -102,7 +102,7 @@ static int acpi_i2c_add_resource(struct acpi_resource *ares, void *data)
                struct acpi_resource_i2c_serialbus *sb;
 
                sb = &ares->data.i2c_serial_bus;
-               if (sb->type == ACPI_RESOURCE_SERIAL_TYPE_I2C) {
+               if (!info->addr && sb->type == ACPI_RESOURCE_SERIAL_TYPE_I2C) {
                        info->addr = sb->slave_address;
                        if (sb->access_mode == ACPI_I2C_10BIT_MODE)
                                info->flags |= I2C_CLIENT_TEN;