xattr: use memdup_user()
authorLi Zefan <lizf@cn.fujitsu.com>
Wed, 8 Apr 2009 07:06:12 +0000 (15:06 +0800)
committerAl Viro <viro@zeniv.linux.org.uk>
Tue, 21 Apr 2009 03:02:50 +0000 (23:02 -0400)
Remove open-coded memdup_user()

Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
fs/xattr.c

index 197c4fcac0323e6de46fed267732c343298d3a07..d51b8f9db921ce4c01c2858cfc56b9ecd6ca71f5 100644 (file)
@@ -237,13 +237,9 @@ setxattr(struct dentry *d, const char __user *name, const void __user *value,
        if (size) {
                if (size > XATTR_SIZE_MAX)
                        return -E2BIG;
-               kvalue = kmalloc(size, GFP_KERNEL);
-               if (!kvalue)
-                       return -ENOMEM;
-               if (copy_from_user(kvalue, value, size)) {
-                       kfree(kvalue);
-                       return -EFAULT;
-               }
+               kvalue = memdup_user(value, size);
+               if (IS_ERR(kvalue))
+                       return PTR_ERR(kvalue);
        }
 
        error = vfs_setxattr(d, kname, kvalue, size, flags);