dmaengine: idma64: use local variable to index descriptor
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Tue, 17 Nov 2015 11:37:10 +0000 (13:37 +0200)
committerVinod Koul <vinod.koul@intel.com>
Sat, 5 Dec 2015 08:24:28 +0000 (13:54 +0530)
Since a local variable contains the number of hardware desriptors at the
beginning of idma64_desc_fill() we may use it to index the last descriptor as
well.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
drivers/dma/idma64.c

index b6c13f9fffb6ed0495d91110025c68933adadc82..3cb7b2c781970fc6e43d11fde0ea8779fbb2a6d1 100644 (file)
@@ -274,10 +274,10 @@ static void idma64_desc_fill(struct idma64_chan *idma64c,
                struct idma64_desc *desc)
 {
        struct dma_slave_config *config = &idma64c->config;
-       struct idma64_hw_desc *hw = &desc->hw[desc->ndesc - 1];
+       unsigned int i = desc->ndesc;
+       struct idma64_hw_desc *hw = &desc->hw[i - 1];
        struct idma64_lli *lli = hw->lli;
        u64 llp = 0;
-       unsigned int i = desc->ndesc;
 
        /* Fill the hardware descriptors and link them to a list */
        do {
@@ -287,7 +287,7 @@ static void idma64_desc_fill(struct idma64_chan *idma64c,
                desc->length += hw->len;
        } while (i);
 
-       /* Trigger interrupt after last block */
+       /* Trigger an interrupt after the last block is transfered */
        lli->ctllo |= IDMA64C_CTLL_INT_EN;
 }