net: systemport: Set correct RSB endian bits based on host
authorFlorian Fainelli <f.fainelli@gmail.com>
Tue, 29 Aug 2017 20:35:17 +0000 (13:35 -0700)
committerDavid S. Miller <davem@davemloft.net>
Tue, 29 Aug 2017 21:42:17 +0000 (14:42 -0700)
RSB_SWAP0 needs to match the host CPU endian, and it needs to be set
for LE and clear for BE. RSB_SWAP1 must always be cleared for SYSTEMPORT
Lite.

With these settings, we have the Receive Status Block always match the
host endian and we do not need to perform any conversion. Since there is
not necessarily a CONFIG_CPU_LITTLE_ENDIAN option defined, we test for
!CONFIG_CPU_BIG_ENDIAN which is guaranteed to be set.

Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/broadcom/bcmsysport.c

index a7e84292af50e9e83a5f0556e0746156106efa5b..931751e4f3692ffa00dfa385a68aad34675117a0 100644 (file)
@@ -1762,10 +1762,14 @@ static void rbuf_init(struct bcm_sysport_priv *priv)
        reg = rbuf_readl(priv, RBUF_CONTROL);
        reg |= RBUF_4B_ALGN | RBUF_RSB_EN;
        /* Set a correct RSB format on SYSTEMPORT Lite */
-       if (priv->is_lite) {
+       if (priv->is_lite)
                reg &= ~RBUF_RSB_SWAP1;
+
+       /* Set a correct RSB format based on host endian */
+       if (!IS_ENABLED(CONFIG_CPU_BIG_ENDIAN))
                reg |= RBUF_RSB_SWAP0;
-       }
+       else
+               reg &= ~RBUF_RSB_SWAP0;
        rbuf_writel(priv, reg, RBUF_CONTROL);
 }