tcp: don't require root to read tcp_metrics
authorBanerjee, Debabrata <dbanerje@akamai.com>
Wed, 30 Jul 2014 17:50:17 +0000 (13:50 -0400)
committerDavid S. Miller <davem@davemloft.net>
Thu, 31 Jul 2014 21:07:37 +0000 (14:07 -0700)
commit d23ff7016 (tcp: add generic netlink support for tcp_metrics) introduced
netlink support for the new tcp_metrics, however it restricted getting of
tcp_metrics to root user only. This is a change from how these values could
have been fetched when in the old route cache. Unless there's a legitimate
reason to restrict the reading of these values it would be better if normal
users could fetch them.

Cc: Julian Anastasov <ja@ssi.bg>
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Debabrata Banerjee <dbanerje@akamai.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/tcp_metrics.c

index 4fe04180598969e653a01db2c459edd2c8d8acce..0d54e59b9ea8c02835674b47e06c8732295ab10c 100644 (file)
@@ -1093,7 +1093,6 @@ static const struct genl_ops tcp_metrics_nl_ops[] = {
                .doit = tcp_metrics_nl_cmd_get,
                .dumpit = tcp_metrics_nl_dump,
                .policy = tcp_metrics_nl_policy,
-               .flags = GENL_ADMIN_PERM,
        },
        {
                .cmd = TCP_METRICS_CMD_DEL,