projects / GitHub / moto-9609 / android_kernel_motorola_exynos9610.git / commitdiff
? search:
summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: 2e1e597)
acornfb: Dont BUG() on invalid pan parameters
authorLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Wed, 25 May 2011 11:43:53 +0000 (13:43 +0200)
committerLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Fri, 19 Aug 2011 08:29:23 +0000 (10:29 +0200)
The driver currently BUG()s if the pan parameters passed directly from
userspace are invalid. Return -EINVAL instead.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
drivers/video/acornfb.c patch | blob | blame | history

diff --git a/drivers/video/acornfb.c b/drivers/video/acornfb.c
index 6183a57eb69d8b913abcde29af3bbdb24714e725..3bacc1290548f21c7e2e7a084448feaaa5fd7bed 100644 (file)
--- a/drivers/video/acornfb.c
+++ b/drivers/video/acornfb.c
@@ -852,7 +852,8 @@ acornfb_pan_display(struct fb_var_screeninfo *var, struct fb_info *info)
        if (!(var->vmode & FB_VMODE_YWRAP))
                y_bottom += var->yres;
 
-       BUG_ON(y_bottom > var->yres_virtual);
+       if (y_bottom > var->yres_virtual)
+               return -EINVAL;
 
        acornfb_update_dma(info, var);