Btrfs: set trans to null in reserve_metadata_bytes if we commit the transaction

btrfs_commit_transaction will free our trans, but because we pass trans to
shrink_delalloc we could possibly have a use after free situation.  So instead
if we commit the transaction, set trans to null and set committed to true so we
don't keep trying to commit a transaction.  This fixes a panic I could reproduce
at will.  Thanks,

Signed-off-by: Josef Bacik <josef@redhat.com>

diff --git a/fs/btrfs/extent-tree.c b/fs/btrfs/extent-tree.c
index 180a50146ddfa4b3766e6293b7c0e4640e4b80a8..e2dfd4ab3b9b0f01cfb117171998b81b9a3cf18c 100644 (file)
--- a/fs/btrfs/extent-tree.c
+++ b/fs/btrfs/extent-tree.c
@@ -3157,6 +3157,7 @@ static int reserve_metadata_bytes(struct btrfs_trans_handle *trans,
        int retries = 0;
        int ret = 0;
        bool reserved = false;
+       bool committed = false;
 
 again:
        ret = -ENOSPC;
@@ -3249,17 +3250,19 @@ again:
                goto out;
 
        ret = -EAGAIN;
-       if (trans)
+       if (trans || committed)
                goto out;
 
-
        ret = -ENOSPC;
        trans = btrfs_join_transaction(root, 1);
        if (IS_ERR(trans))
                goto out;
        ret = btrfs_commit_transaction(trans, root);
-       if (!ret)
+       if (!ret) {
+               trans = NULL;
+               committed = true;
                goto again;
+       }
 
 out:
        if (reserved) {