dmaengine: ipu: use return value of request_irq
authorVinod Koul <vinod.koul@intel.com>
Fri, 25 Jul 2014 10:09:50 +0000 (15:39 +0530)
committerVinod Koul <vinod.koul@intel.com>
Fri, 25 Jul 2014 10:09:50 +0000 (15:39 +0530)
Commit - 653e67f7e5: "dmaengine: inherit debug settings from the subsystem
for subdirectories" introduced debug option for subdirectories too
This exposed issue with ipu driver not using return value

For now just warn users about it

Reported-by: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
drivers/dma/ipu/ipu_idmac.c

index 128ca143486d1b59c0106cb8a177b5a2e1b803fd..bbf62927bd72f4caa20b6fb19f4bae64042864b1 100644 (file)
@@ -1532,11 +1532,17 @@ static int idmac_alloc_chan_resources(struct dma_chan *chan)
 #ifdef DEBUG
        if (chan->chan_id == IDMAC_IC_7) {
                ic_sof = ipu_irq_map(69);
-               if (ic_sof > 0)
-                       request_irq(ic_sof, ic_sof_irq, 0, "IC SOF", ichan);
+               if (ic_sof > 0) {
+                       ret = request_irq(ic_sof, ic_sof_irq, 0, "IC SOF", ichan);
+                       if (ret)
+                               dev_err(&chan->dev->device, "request irq failed for IC SOF");
+               }
                ic_eof = ipu_irq_map(70);
-               if (ic_eof > 0)
-                       request_irq(ic_eof, ic_eof_irq, 0, "IC EOF", ichan);
+               if (ic_eof > 0) {
+                       ret = request_irq(ic_eof, ic_eof_irq, 0, "IC EOF", ichan);
+                       if (ret)
+                               dev_err(&chan->dev->device, "request irq failed for IC EOF");
+               }
        }
 #endif