locks: pass the cmd value to fcntl_getlk/getlk64

Once we introduce file private locks, we'll need to know what cmd value
was used, as that affects the ownership and whether a conflict would
arise.

Signed-off-by: Jeff Layton <jlayton@redhat.com>
Change-Id: Iaeb8233ae25bde5ef0049118ff94e4a9e0f02214
Signed-off-by: Kevin F. Haggerty <haggertk@lineageos.org>

diff --git a/fs/fcntl.c b/fs/fcntl.c
index 0ec0ab37e8c3599dc89cf888d85bbdfb0dcc42cc..d67ee2c7de68b8510ae78475fb72183bd62f2109 100644 (file)
--- a/fs/fcntl.c
+++ b/fs/fcntl.c
@@ -275,7 +275,7 @@ static long do_fcntl(int fd, unsigned int cmd, unsigned long arg,
                err = setfl(fd, filp, arg);
                break;
        case F_GETLK:
-               err = fcntl_getlk(filp, (struct flock __user *) arg);
+               err = fcntl_getlk(filp, cmd, (struct flock __user *) arg);
                break;
        case F_SETLK:
        case F_SETLKW:
@@ -395,7 +395,7 @@ SYSCALL_DEFINE3(fcntl64, unsigned int, fd, unsigned int, cmd,
        
        switch (cmd) {
                case F_GETLK64:
-                       err = fcntl_getlk64(f.file, (struct flock64 __user *) arg);
+                       err = fcntl_getlk64(f.file, cmd, (struct flock64 __user *) arg);
                        break;
                case F_SETLK64:
                case F_SETLKW64:

diff --git a/fs/locks.c b/fs/locks.c
index da11d6fab463531f50ffc4f95140d690f32a2925..ffb7a049a663c57345c56872856dd5eea8c8620b 100644 (file)
--- a/fs/locks.c
+++ b/fs/locks.c
@@ -1721,7 +1721,7 @@ static void posix_lock_to_flock64(struct flock64 *flock, struct file_lock *fl)
 /* Report the first existing lock that would conflict with l.
  * This implements the F_GETLK command of fcntl().
  */
-int fcntl_getlk(struct file *filp, struct flock __user *l)
+int fcntl_getlk(struct file *filp, unsigned int cmd, struct flock __user *l)
 {
        struct file_lock file_lock;
        struct flock flock;
@@ -1908,7 +1908,7 @@ out:
 /* Report the first existing lock that would conflict with l.
  * This implements the F_GETLK command of fcntl().
  */
-int fcntl_getlk64(struct file *filp, struct flock64 __user *l)
+int fcntl_getlk64(struct file *filp, unsigned int cmd, struct flock64 __user *l)
 {
        struct file_lock file_lock;
        struct flock64 flock;

diff --git a/include/linux/fs.h b/include/linux/fs.h
index 03206754da7fbf7764ab3e3f245481c598aeb299..5fa6ee4d4b9529fb083743e904519fbac5203f08 100644 (file)
--- a/include/linux/fs.h
+++ b/include/linux/fs.h
@@ -1028,12 +1028,12 @@ struct file_lock {
 extern void send_sigio(struct fown_struct *fown, int fd, int band);
 
 #ifdef CONFIG_FILE_LOCKING
-extern int fcntl_getlk(struct file *, struct flock __user *);
+extern int fcntl_getlk(struct file *, unsigned int, struct flock __user *);
 extern int fcntl_setlk(unsigned int, struct file *, unsigned int,
                        struct flock __user *);
 
 #if BITS_PER_LONG == 32
-extern int fcntl_getlk64(struct file *, struct flock64 __user *);
+extern int fcntl_getlk64(struct file *, unsigned int, struct flock64 __user *);
 extern int fcntl_setlk64(unsigned int, struct file *, unsigned int,
                        struct flock64 __user *);
 #endif
@@ -1069,7 +1069,8 @@ extern void locks_delete_block(struct file_lock *waiter);
 extern void lock_flocks(void);
 extern void unlock_flocks(void);
 #else /* !CONFIG_FILE_LOCKING */
-static inline int fcntl_getlk(struct file *file, struct flock __user *user)
+static inline int fcntl_getlk(struct file *file, unsigned int cmd,
+                             struct flock __user *user)
 {
        return -EINVAL;
 }
@@ -1081,7 +1082,8 @@ static inline int fcntl_setlk(unsigned int fd, struct file *file,
 }
 
 #if BITS_PER_LONG == 32
-static inline int fcntl_getlk64(struct file *file, struct flock64 __user *user)
+static inline int fcntl_getlk64(struct file *file, unsigned int cmd,
+                               struct flock64 __user *user)
 {
        return -EINVAL;
 }