hwmon: (it87) Fix VID reading on IT8718F/IT8720F
authorJean Delvare <khali@linux-fr.org>
Sat, 24 Oct 2009 11:28:47 +0000 (13:28 +0200)
committerJean Delvare <khali@linux-fr.org>
Sat, 24 Oct 2009 11:28:47 +0000 (13:28 +0200)
Comparing apples to bananas doesn't seem right. Consistently use the
chips enum for chip type comparisons, to avoid such bugs in the
future.

The bug has been there since support for the IT8718F was added, so
VID never worked for this chip nor for the similar IT8720F.

Signed-off-by: Jean Delvare <khali@linux-fr.org>
drivers/hwmon/it87.c

index ffeb2a10e1a76c59f090e6d8082a7a089a96f502..a3749cb0f181ec623a4d628ea615c66a154a6c5e 100644 (file)
@@ -1028,12 +1028,11 @@ static int __init it87_find(unsigned short *address,
                chip_type, *address, sio_data->revision);
 
        /* Read GPIO config and VID value from LDN 7 (GPIO) */
-       if (chip_type != IT8705F_DEVID) {
+       if (sio_data->type != it87) {
                int reg;
 
                superio_select(GPIO);
-               if ((chip_type == it8718) ||
-                   (chip_type == it8720))
+               if (sio_data->type == it8718 || sio_data->type == it8720)
                        sio_data->vid_value = superio_inb(IT87_SIO_VID_REG);
 
                reg = superio_inb(IT87_SIO_PINX2_REG);