clocksource: cyclone: Add missing iounmap

Add missing iounmap in error handling code, in a case where the function
already preforms iounmap on some other execution path.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@@
expression e;
statement S,S1;
int ret;
@@
e = \(ioremap\|ioremap_nocache\)(...)
... when != iounmap(e)
if (<+...e...+>) S
... when any
    when != iounmap(e)
*if (...)
   { ... when != iounmap(e)
     return ...; }
... when any
iounmap(e);
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
[fixed up subject -jstultz]
Signed-off-by: John Stultz <john.stultz@linaro.org>

diff --git a/drivers/clocksource/cyclone.c b/drivers/clocksource/cyclone.c
index 72f811f73e9c7807796e4da2814e3845d5986a0b..9e0998f22885271fa9c7aa5f778d309ade0a3dd2 100644 (file)
--- a/drivers/clocksource/cyclone.c
+++ b/drivers/clocksource/cyclone.c
@@ -55,11 +55,11 @@ static int __init init_cyclone_clocksource(void)
        }
        /* even on 64bit systems, this is only 32bits: */
        base = readl(reg);
+       iounmap(reg);
        if (!base) {
                printk(KERN_ERR "Summit chipset: Could not find valid CBAR value.\n");
                return -ENODEV;
        }
-       iounmap(reg);
 
        /* setup PMCC: */
        offset = base + CYCLONE_PMCC_OFFSET;