iio: amplifiers: ad8366: Use devm_* APIs
authorSachin Kamat <sachin.kamat@linaro.org>
Tue, 30 Jul 2013 06:24:00 +0000 (07:24 +0100)
committerJonathan Cameron <jic23@kernel.org>
Sat, 3 Aug 2013 20:00:15 +0000 (21:00 +0100)
devm_* APIs are device managed and make code simpler.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Cc: Michael Hennerich <hennerich@blackfin.uclinux.org>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
drivers/iio/amplifiers/ad8366.c

index d354554b51b3e072bbfc260eb945d215332c1933..d0a79a4bce1c8f5d83410392e3343d779b015e2a 100644 (file)
@@ -139,17 +139,17 @@ static int ad8366_probe(struct spi_device *spi)
        struct ad8366_state *st;
        int ret;
 
-       indio_dev = iio_device_alloc(sizeof(*st));
+       indio_dev = devm_iio_device_alloc(&spi->dev, sizeof(*st));
        if (indio_dev == NULL)
                return -ENOMEM;
 
        st = iio_priv(indio_dev);
 
-       st->reg = regulator_get(&spi->dev, "vcc");
+       st->reg = devm_regulator_get(&spi->dev, "vcc");
        if (!IS_ERR(st->reg)) {
                ret = regulator_enable(st->reg);
                if (ret)
-                       goto error_put_reg;
+                       return ret;
        }
 
        spi_set_drvdata(spi, indio_dev);
@@ -173,11 +173,6 @@ static int ad8366_probe(struct spi_device *spi)
 error_disable_reg:
        if (!IS_ERR(st->reg))
                regulator_disable(st->reg);
-error_put_reg:
-       if (!IS_ERR(st->reg))
-               regulator_put(st->reg);
-
-       iio_device_free(indio_dev);
 
        return ret;
 }
@@ -195,8 +190,6 @@ static int ad8366_remove(struct spi_device *spi)
                regulator_put(reg);
        }
 
-       iio_device_free(indio_dev);
-
        return 0;
 }