perf c2c report: Add 'pid' sort key
authorJiri Olsa <jolsa@kernel.org>
Tue, 24 May 2016 11:09:47 +0000 (13:09 +0200)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Wed, 19 Oct 2016 16:18:31 +0000 (13:18 -0300)
It is to be displayed in the single cacheline output:

  pid

We currently don't have a single 'pid' sort/display entry, which would
output just pid number, hence adding it into c2c code.

Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Cc: Andi Kleen <andi@firstfloor.org>
Cc: David Ahern <dsahern@gmail.com>
Cc: Don Zickus <dzickus@redhat.com>
Cc: Joe Mario <jmario@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/n/tip-3o23qrspxc99b04ci1swlzr6@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/builtin-c2c.c

index c718d8b553ce136fa90b6df789e5a3deb7ab389d..4795713ad2118d2c79b617a3fa26e718e1195626 100644 (file)
@@ -810,6 +810,22 @@ percent_stores_l1miss_cmp(struct perf_hpp_fmt *fmt __maybe_unused,
 STAT_FN(lcl_dram)
 STAT_FN(rmt_dram)
 
+static int
+pid_entry(struct perf_hpp_fmt *fmt, struct perf_hpp *hpp,
+         struct hist_entry *he)
+{
+       int width = c2c_width(fmt, hpp, he->hists);
+
+       return scnprintf(hpp->buf, hpp->size, "%*d", width, he->thread->pid_);
+}
+
+static int64_t
+pid_cmp(struct perf_hpp_fmt *fmt __maybe_unused,
+       struct hist_entry *left, struct hist_entry *right)
+{
+       return left->thread->pid_ - right->thread->pid_;
+}
+
 #define HEADER_LOW(__h)                        \
        {                               \
                .line[1] = {            \
@@ -1074,6 +1090,14 @@ static struct c2c_dimension dim_dram_rmt = {
        .width          = 8,
 };
 
+static struct c2c_dimension dim_pid = {
+       .header         = HEADER_LOW("Pid"),
+       .name           = "pid",
+       .cmp            = pid_cmp,
+       .entry          = pid_entry,
+       .width          = 7,
+};
+
 static struct c2c_dimension *dimensions[] = {
        &dim_dcacheline,
        &dim_offset,
@@ -1103,6 +1127,7 @@ static struct c2c_dimension *dimensions[] = {
        &dim_percent_stores_l1miss,
        &dim_dram_lcl,
        &dim_dram_rmt,
+       &dim_pid,
        NULL,
 };