dma: at_hdmac: remove unnecessary platform_set_drvdata()
authorJingoo Han <jg1.han@samsung.com>
Mon, 6 May 2013 03:53:33 +0000 (12:53 +0900)
committerVinod Koul <vinod.koul@intel.com>
Fri, 5 Jul 2013 06:10:34 +0000 (11:40 +0530)
The driver core clears the driver data to NULL after device_release
or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
(device-core: Ensure drvdata = NULL when no driver is bound).
Thus, it is not needed to manually clear the device driver data to NULL.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
drivers/dma/at_hdmac.c

index 5ce89368a8db28a76d1b1e593298da6b9bfbdf23..6db5228f41340071e9f0ce4a1834bdc392ec7fa6 100644 (file)
@@ -1570,7 +1570,6 @@ err_of_dma_controller_register:
        dma_async_device_unregister(&atdma->dma_common);
        dma_pool_destroy(atdma->dma_desc_pool);
 err_pool_create:
-       platform_set_drvdata(pdev, NULL);
        free_irq(platform_get_irq(pdev, 0), atdma);
 err_irq:
        clk_disable(atdma->clk);
@@ -1595,7 +1594,6 @@ static int at_dma_remove(struct platform_device *pdev)
        dma_async_device_unregister(&atdma->dma_common);
 
        dma_pool_destroy(atdma->dma_desc_pool);
-       platform_set_drvdata(pdev, NULL);
        free_irq(platform_get_irq(pdev, 0), atdma);
 
        list_for_each_entry_safe(chan, _chan, &atdma->dma_common.channels,