mtd: cfi_cmdset_0002: allow retry/timeout loop to exit
authorBrian Norris <computersforpeace@gmail.com>
Tue, 22 Jul 2014 02:06:19 +0000 (19:06 -0700)
committerBrian Norris <computersforpeace@gmail.com>
Tue, 19 Aug 2014 18:53:07 +0000 (11:53 -0700)
The variable 'retries' is never modified, so if the reset operation
never is going to complete, we'll get stuck in an infinite loop.

It looks like the intention was to decrement 'retries' on every loop.
Untested.

Caught by Coverity.

Signed-off-by: Brian Norris <computersforpeace@gmail.com>
drivers/mtd/chips/cfi_cmdset_0002.c

index 5a4bfe33112aba9307bdeac6877a4404b24bc7e7..6da141af9cba3492297de28e92246f6fead4a5be 100644 (file)
@@ -2029,6 +2029,8 @@ static int cfi_amdstd_panic_wait(struct map_info *map, struct flchip *chip,
 
                        udelay(1);
                }
+
+               retries--;
        }
 
        /* the chip never became ready */