projects
/
GitHub
/
moto-9609
/
android_kernel_motorola_exynos9610.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
8434e78
)
iio: dac: ad5686: Don't set error code to voltage_uv
author
Axel Lin
<axel.lin@ingics.com>
Fri, 14 Dec 2012 12:08:00 +0000
(12:08 +0000)
committer
Jonathan Cameron
<jic23@kernel.org>
Thu, 27 Dec 2012 11:00:22 +0000
(11:00 +0000)
regulator_get_voltage() may return negative error code.
Add error checking to avoid setting error code to voltage_uv.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
Acked-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
drivers/iio/dac/ad5686.c
patch
|
blob
|
blame
|
history
diff --git
a/drivers/iio/dac/ad5686.c
b/drivers/iio/dac/ad5686.c
index bc92ff9309c2b6012c0cfd25ac36bb8f54898690..01eb1d0e4e4162e8fb7a7f09abd642e8e3ab583a 100644
(file)
--- a/
drivers/iio/dac/ad5686.c
+++ b/
drivers/iio/dac/ad5686.c
@@
-332,7
+332,11
@@
static int __devinit ad5686_probe(struct spi_device *spi)
if (ret)
goto error_put_reg;
- voltage_uv = regulator_get_voltage(st->reg);
+ ret = regulator_get_voltage(st->reg);
+ if (ret < 0)
+ goto error_disable_reg;
+
+ voltage_uv = ret;
}
st->chip_info =