projects
/
GitHub
/
LineageOS
/
G12
/
android_kernel_amlogic_linux-4.9.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
e36f014
)
Mailbox: Fix return value check in pcc_init()
author
Wei Yongjun
<yongjun_wei@trendmicro.com.cn>
Wed, 14 Jan 2015 01:10:56 +0000
(09:10 +0800)
committer
Jassi Brar
<jaswinder.singh@linaro.org>
Fri, 6 Feb 2015 05:27:56 +0000
(10:57 +0530)
In case of error, the function platform_create_bundle() returns
ERR_PTR() and never returns NULL. The NULL test in the return value
check should be replaced with IS_ERR().
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
drivers/mailbox/pcc.c
patch
|
blob
|
blame
|
history
diff --git
a/drivers/mailbox/pcc.c
b/drivers/mailbox/pcc.c
index 6dbf6fcbdfaf1671163eba8b8345c21a5566b173..70576fb707a5be482774d91e265c4be8b6e49f47 100644
(file)
--- a/
drivers/mailbox/pcc.c
+++ b/
drivers/mailbox/pcc.c
@@
-393,9
+393,9
@@
static int __init pcc_init(void)
pcc_pdev = platform_create_bundle(&pcc_mbox_driver,
pcc_mbox_probe, NULL, 0, NULL, 0);
- if (
!pcc_pdev
) {
+ if (
IS_ERR(pcc_pdev)
) {
pr_err("Err creating PCC platform bundle\n");
- return
-ENODEV
;
+ return
PTR_ERR(pcc_pdev)
;
}
return 0;