amd64_edac: Beef up early exit reporting
authorBorislav Petkov <borislav.petkov@amd.com>
Mon, 17 Jan 2011 12:03:26 +0000 (13:03 +0100)
committerBorislav Petkov <borislav.petkov@amd.com>
Thu, 17 Mar 2011 13:46:22 +0000 (14:46 +0100)
Add paranoid checks for the sys address before going off and decoding
it.

Signed-off-by: Borislav Petkov <borislav.petkov@amd.com>
drivers/edac/amd64_edac.c

index 4bba43e7ee857a933ab7e5789f917066e330d806..e4ad09110b96ab76e3b2a7a10c123df1ace55b0d 100644 (file)
@@ -1380,9 +1380,20 @@ static int f10_match_to_this_node(struct amd64_pvt *pvt, int range,
        debugf1("(range %d) SystemAddr= 0x%llx Limit=0x%llx\n",
                range, sys_addr, get_dram_limit(pvt, range));
 
+       if (dhar_valid(pvt) &&
+           dhar_base(pvt) <= sys_addr &&
+           sys_addr < BIT_64(32)) {
+               amd64_warn("Huh? Address is in the MMIO hole: 0x%016llx\n",
+                           sys_addr);
+               return -EINVAL;
+       }
+
        if (intlv_en &&
-           (intlv_sel != ((sys_addr >> 12) & intlv_en)))
+           (intlv_sel != ((sys_addr >> 12) & intlv_en))) {
+               amd64_warn("Botched intlv bits, en: 0x%x, sel: 0x%x\n",
+                          intlv_en, intlv_sel);
                return -EINVAL;
+       }
 
        sys_addr = f10_swap_interleaved_region(pvt, sys_addr);